netdev - RE: [patch net-next 1/9] Introduce devlink infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO2PR11MB00885BBB4561C21A524A78E797A50@CO2PR11MB0088.namprd11.prod.outlook.com>
Date:	Wed, 24 Feb 2016 07:02:32 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Jiri Pirko <jiri@...nulli.us>, netdev <netdev@...r.kernel.org>
CC:	David Miller <davem@...emloft.net>,
	"idosch@...lanox.com" <idosch@...lanox.com>,
	"eladr@...lanox.com" <eladr@...lanox.com>,
	"yotamg@...lanox.com" <yotamg@...lanox.com>,
	"ogerlitz@...lanox.com" <ogerlitz@...lanox.com>,
	"yishaih@...lanox.com" <yishaih@...lanox.com>,
	"dledford@...hat.com" <dledford@...hat.com>,
	"sean.hefty@...el.com" <sean.hefty@...el.com>,
	"hal.rosenstock@...il.com" <hal.rosenstock@...il.com>,
	"eugenia@...lanox.com" <eugenia@...lanox.com>,
	"roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>,
	"nikolay@...ulusnetworks.com" <nikolay@...ulusnetworks.com>,
	"hadarh@...lanox.com" <hadarh@...lanox.com>,
	"jhs@...atatu.com" <jhs@...atatu.com>,
	"john.fastabend@...il.com" <john.fastabend@...il.com>,
	"jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
	"brouer@...hat.com" <brouer@...hat.com>,
	"ivecera@...hat.com" <ivecera@...hat.com>,
	"rami.rosen@...el.com" <rami.rosen@...el.com>
Subject: RE: [patch net-next 1/9] Introduce devlink infrastructure

> + * An overall lock guarding every operation comming from userspace.
> + * If also guards devlink devices list and it is taken when
> + * driver registers/unregisters it.
Several typos in comment.

> +static void devlink_notify(struct devlink *devlink, enum
> +devlink_command cmd) {
...
> +	WARN_ON(cmd != DEVLINK_CMD_NEW && cmd !=
> DEVLINK_CMD_DEL);
Given this should never happen, shouldn't this be ONCE?

> +static void devlink_port_notify(struct devlink_port *devlink_port,
...
> +	WARN_ON(cmd != DEVLINK_CMD_PORT_NEW && cmd !=
> DEVLINK_CMD_PORT_DEL);
Likewise

> +static void __devlink_port_type_set(struct devlink_port *devlink_port,
...
> +	devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_NEW); }
Why is this PORT_NEW? Shouldn't it be PORT_SET?
Also, curly bracers are repeatedly on last line of function [if this file].
Is this by design?