netdev - Re: [PATCHv2] net: fix bridge multicast packet checksum validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201602240911.PtsxZOS1%fengguang.wu@intel.com>
Date:	Wed, 24 Feb 2016 09:27:56 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Linus Lüssing <linus.luessing@...3.blue>
Cc:	kbuild-all@...org, netdev@...r.kernel.org,
	"David S . Miller" <davem@...emloft.net>,
	Stephen Hemminger <stephen@...workplumber.org>,
	bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	"Steinar H . Gunderson" <sgunderson@...foot.com>,
	Álvaro Fernández Rojas <noltari@...il.com>,
	Tom Herbert <tom@...bertland.com>,
	Linus Lüssing <linus.luessing@...3.blue>
Subject: Re: [PATCHv2] net: fix bridge multicast packet checksum validation

Hi Linus,

[auto build test ERROR on net/master]
[also build test ERROR on v4.5-rc5 next-20160223]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Linus-L-ssing/net-fix-bridge-multicast-packet-checksum-validation/20160224-091615
config: i386-randconfig-x004-201608 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from include/linux/ip.h:20:0,
                    from include/net/ip.h:26,
                    from include/linux/errqueue.h:5,
                    from net/core/sock.c:96:
>> include/linux/skbuff.h:2826:20: error: redefinition of 'skb_postpush_rcsum'
    static inline void skb_postpush_rcsum(struct sk_buff *skb,
                       ^
   include/linux/skbuff.h:2796:20: note: previous definition of 'skb_postpush_rcsum' was here
    static inline void skb_postpush_rcsum(struct sk_buff *skb,
                       ^

vim +/skb_postpush_rcsum +2826 include/linux/skbuff.h

31b33dfb Pravin B Shelar 2015-09-28  2820  		 skb_checksum_start_offset(skb) < 0)
6ae459bd Pravin B Shelar 2015-09-22  2821  		skb->ip_summed = CHECKSUM_NONE;
^1da177e Linus Torvalds  2005-04-16  2822  }
^1da177e Linus Torvalds  2005-04-16  2823  
cbb042f9 Herbert Xu      2006-03-20  2824  unsigned char *skb_pull_rcsum(struct sk_buff *skb, unsigned int len);
cbb042f9 Herbert Xu      2006-03-20  2825  
f8ffad69 Daniel Borkmann 2016-01-07 @2826  static inline void skb_postpush_rcsum(struct sk_buff *skb,
f8ffad69 Daniel Borkmann 2016-01-07  2827  				      const void *start, unsigned int len)
f8ffad69 Daniel Borkmann 2016-01-07  2828  {
f8ffad69 Daniel Borkmann 2016-01-07  2829  	/* For performing the reverse operation to skb_postpull_rcsum(),

:::::: The code at line 2826 was first introduced by commit
:::::: f8ffad69c9f8b8dfb0b633425d4ef4d2493ba61a bpf: add skb_postpush_rcsum and fix dev_forward_skb occasions

:::::: TO: Daniel Borkmann <daniel@...earbox.net>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (26750 bytes)