netdev - Re: [Y2038] [PATCH 1/4] kernel: time: Add current_nw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6117501.V63TZYo9Wq@wuerfel>
Date:	Thu, 25 Feb 2016 15:56:30 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	y2038@...ts.linaro.org
Cc:	Deepa Dinamani <deepa.kernel@...il.com>, netdev@...r.kernel.org,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	James Morris <jmorris@...ei.org>,
	Patrick McHardy <kaber@...sh.net>,
	John Stultz <john.stultz@...aro.org>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	Thomas Gleixner <tglx@...utronix.de>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Y2038] [PATCH 1/4] kernel: time: Add current_nw_timestamp() for network timestamps

On Wednesday 24 February 2016 23:07:08 Deepa Dinamani wrote:
> ICMP timestamp messages and IP source route options require
> timestamps to be in milliseconds modulo 24 hours from
> midnight UTC format.
> 
> Add a time function to support this. The function returns the
> required timestamp in network byte order.
> 
> The function also uses y2038 safe time functions and data
> structures.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
> 

For the implementation:

Reviewed-by: Arnd Bergmann <arnd@...db.de>

For where to put the code, I have no better idea, but I agree
with Hideaki Yoshifuji that it's a bit odd to place it in
kernel/*.c when it's only used by net/ipv4.

	Arnd