netdev - Re: [PATCH 2/4] net: ipv4: Use y2038 safe functions and data structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4264103.2ioXPnMr1j@wuerfel>
Date:	Thu, 25 Feb 2016 15:57:49 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Deepa Dinamani <deepa.kernel@...il.com>
Cc:	netdev@...r.kernel.org, y2038@...ts.linaro.org,
	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH 2/4] net: ipv4: Use y2038 safe functions and data structures

On Wednesday 24 February 2016 23:07:09 Deepa Dinamani wrote:
> ICMP timestamp messages and IP source route options require
> timestamps to be in milliseconds modulo 24 hours from
> midnight UT format.
> 
> Timestamps are calculated from realtime by making a call
> to getnstimeofday() which uses struct timespec.
> timespec is not y2038 safe.
> Replace the above calls with y2038 safe current_nw_time() to
> obtain network timestamps which uses y2038 safe struct timespec64.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
> 

Reviewed-by: Arnd Bergmann <arnd@...db.de>