lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Feb 2016 16:37:33 +0100 From: Paolo Abeni <pabeni@...hat.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Stephen Hemminger <stephen@...workplumber.org>, Pravin Shelar <pshelar@...ira.com>, Jesse Gross <jesse@...nel.org>, Flavio Leitner <fbl@...close.org>, Hannes Frederic Sowa <hannes@...essinduktion.org> Subject: Re: [PATCH net-next v2 1/5] netdev: introduce ndo_set_rx_headroom On Thu, 2016-02-25 at 17:21 +0300, Sergei Shtylyov wrote: > Hello. > > On 2/25/2016 2:09 PM, Paolo Abeni wrote: > > > This method allows the controlling device (i.e. the bridge) to specify > > additional headroom to be allocated for skb head on frame reception. > > > > Signed-off-by: Paolo Abeni <pabeni@...hat.com> > > > > --- > > v1 -> v2: > > - fixed netdev_get_fwd_headroom() > > - added netdev_set_rx_headroom() and netdev_reset_rx_headroom() helpers > > --- > > include/linux/netdevice.h | 31 +++++++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index e52077f..8f53674 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -1093,6 +1093,12 @@ struct tc_to_netdev { > > * This function is used to get egress tunnel information for given skb. > > * This is useful for retrieving outer tunnel header parameters while > > * sampling packet. > > + * * int (*ndo_set_rx_headroom)(struct net_device *dev, int needed_headroom); > > It's *void* in the declaration. You are right, thank you! must be 'void' here, too. I'll fix it in v3. Paolo
Powered by blists - more mailing lists