netdev - Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160225.170957.836114237953219422.davem@davemloft.net>
Date:	Thu, 25 Feb 2016 17:09:57 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f6bvp@...e.fr
Cc:	netdev@...r.kernel.org, ralf@...ux-mips.org
Subject: Re: [Patch] rose_route_frame() NULL pointer dereference kernel
 panic

From: f6bvp <f6bvp@...e.fr>
Date: Wed, 24 Feb 2016 17:53:11 +0100

> @@ -863,6 +863,11 @@ int rose_route_frame(struct sk_buff *skb, ax25_cb
> *ax25)

First of all this patch was corrupted by your email client.

>         int res = 0;
>         char buf[11];
> 
> +       if (ax25 == NULL) {
> +               printk("Null ax25 destination !\n");
> +               return res;
> +       }

Second of all, this log message is not appropriate, especially given that
rose_xmit() calls rose_rout_frame() with an explicit NULL second argument.