netdev - Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56CEF0C2.4000901@mojatatu.com>
Date:	Thu, 25 Feb 2016 07:17:06 -0500
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [Patch net-next v2 2/2] net_sched: add network namespace support
 for tc actions

On 16-02-24 12:21 PM, Cong Wang wrote:
> On Wed, Feb 24, 2016 at 5:19 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
[..]
>> Did you mean something else or am i missing the obvious?
>> I am looking at the call sites for tcf_action_destroy():
>> -tc_dump_tfilter() has access to *net
>> -tcf_exts_change() - one level lower it has access to *net; i think you
>> added this to your patch too.
>> -tcf_action_init() has *net.
>
> Well, having net is not enough, we still need net_id to retrieve hinfo,

I thought you could pass a pointer to the net_id from all those call
sites? Anyways, we can worry about that later.

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>