netdev - Re: [net-next PATCH] GSO: Provide software checksum of tunneled UDP fragmentation offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160226.142452.543171201728476637.davem@davemloft.net>
Date:	Fri, 26 Feb 2016 14:24:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	aduyck@...antis.com
Cc:	netdev@...r.kernel.org, alexander.duyck@...il.com
Subject: Re: [net-next PATCH] GSO: Provide software checksum of tunneled
 UDP fragmentation offload

From: Alexander Duyck <aduyck@...antis.com>
Date: Wed, 24 Feb 2016 16:46:21 -0800

> On reviewing the code I realized that GRE and UDP tunnels could cause a
> kernel panic if we used GSO to segment a large UDP frame that was sent
> through the tunnel with an outer checksum and hardware offloads were not
> available.
> 
> In order to correct this we need to update the feature flags that are
> passed to the skb_segment function so that in the event of UDP
> fragmentation being requested for the inner header the segmentation
> function will correctly generate the checksum for the payload if we cannot
> segment the outer header.
> 
> Signed-off-by: Alexander Duyck <aduyck@...antis.com>

Applied, thanks Alex.