netdev - Re: [PATCH] net: ndo_fdb_dump should report -EMSGSIZE to rtnl_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160226.150458.1711282575316157924.davem@davemloft.net>
Date:	Fri, 26 Feb 2016 15:04:58 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	minoura@...inux.co.jp
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: ndo_fdb_dump should report -EMSGSIZE to
 rtnl_fdb_dump.

From: MINOURA Makoto / 箕浦 真 <minoura@...inux.co.jp>
Date: Thu, 25 Feb 2016 14:20:48 +0900

> When the send skbuff reaches the end, nlmsg_put and friends returns
> -EMSGSIZE but it is silently thrown away in ndo_fdb_dump. It is called
> within a for_each_netdev loop and the first fdb entry of a following
> netdev could fit in the remaining skbuff.  This breaks the mechanism
> of cb->args[0] and idx to keep track of the entries that are already
> dumped, which results missing entries in bridge fdb show command.
> 
> Signed-off-by: Minoura Makoto <minoura@...inux.co.jp>

Good catch, applied, thanks.