netdev - Re: [PATCH] net: ezchip: adapt driver to little endian architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160226.152519.25582868690139177.davem@davemloft.net>
Date:	Fri, 26 Feb 2016 15:25:19 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	Lada.Trimasova@...opsys.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Alexey.Brodkin@...opsys.com,
	noamc@...hip.com, talz@...hip.com
Subject: Re: [PATCH] net: ezchip: adapt driver to little endian architecture

From: Arnd Bergmann <arnd@...db.de>
Date: Fri, 26 Feb 2016 21:10:31 +0100

> On Friday 26 February 2016 22:05:09 Lada Trimasova wrote:
>>                 for (i = 0; i < len; i++, reg++) {
>>                         u32 buf = nps_enet_reg_get(priv, NPS_ENET_REG_RX_BUF);
>> +                       buf = be32_to_cpu(buf);
>>                         put_unaligned(buf, reg);
>>                 }
> 
> I think most of the changes can make use of the put_unaligned_be32()
> etc helpers that might also be more efficient.

Agreed.