netdev - Re: header conflict introduced by change to netfilter_ipv4/ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160226091307.GA20785@pox.localdomain>
Date:	Fri, 26 Feb 2016 10:13:07 +0100
From:	Thomas Graf <tgraf@...g.ch>
To:	Mikko Rapeli <mikko.rapeli@....fi>
Cc:	Stephen Hemminger <shemming@...cade.com>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re: header conflict introduced by change to
 netfilter_ipv4/ip_tables.h

On 02/26/16 at 09:18am, Mikko Rapeli wrote:
> On Thu, Feb 25, 2016 at 10:08:56PM +0100, Thomas Graf wrote:
> > There is another issue with this commit. iptables.h included from m_ipt.c
> > includes  xtables.h which includes <xtables-version.h> which is not
> > available on a system without xtables.
> > 
> > gcc -Wall -Wstrict-prototypes  -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -O2 -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -DHAVE_SETNS -DHAVE_ELF -DCONFIG_GACT -DCONFIG_GACT_PROB -DIPT_LIB_DIR=\"/lib/xtables\" -DYY_NO_INPUT   -c -o m_ipt.o m_ipt.c
> > In file included from ../include/iptables.h:5:0,
> >                  from m_ipt.c:17:
> > ../include/xtables.h:34:29: fatal error: xtables-version.h: No such file or directory
> >  #include <xtables-version.h>
> 
> I don't see any dependencies from kernel side uapi headers to iptables or
> xtables in my tree based on v4.5-rc2. Maybe this is a problem in
> iproute2.

Right, it's an iproute2 issue in the commit to backport these original
changes to iproute2:

commit 5cd1adba79d33644debd4ba498bb262c5bebcfba
Author: Stephen Hemminger <stephen@...workplumber.org>
Date:   Sun Jan 3 15:14:27 2016 -0800

    Update to current iptables headers
    
    Keep in sync with current iptables upstream