netdev - Re: [PATCH v2 2/3] net: ipv4: tcp_probe: Replace timespec with timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D3C8A5.5090507@miraclelinux.com>
Date:	Mon, 29 Feb 2016 13:27:17 +0900
From:	YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com>
To:	Deepa Dinamani <deepa.kernel@...il.com>, netdev@...r.kernel.org,
	y2038@...ts.linaro.org
Cc:	hideaki.yoshifuji@...aclelinux.com, arnd@...db.de,
	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH v2 2/3] net: ipv4: tcp_probe: Replace timespec with
 timespec64



Deepa Dinamani wrote:
> TCP probe log timestamps use struct timespec which is
> not y2038 safe. Even though timespec might be good enough here
> as it is used to represent delta time, the plan is to get rid
> of all uses of timespec in the kernel.
> Replace with struct timespec64 which is y2038 safe.
> 
> Prints still use unsigned long format and type.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>

Acked-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>

> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru>
> Cc: James Morris <jmorris@...ei.org>
> Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> Cc: Patrick McHardy <kaber@...sh.net>
> ---
>  net/ipv4/tcp_probe.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c
> index ebf5ff5..f6c50af 100644
> --- a/net/ipv4/tcp_probe.c
> +++ b/net/ipv4/tcp_probe.c
> @@ -187,13 +187,13 @@ static int tcpprobe_sprint(char *tbuf, int n)
>  {
>  	const struct tcp_log *p
>  		= tcp_probe.log + tcp_probe.tail;
> -	struct timespec tv
> -		= ktime_to_timespec(ktime_sub(p->tstamp, tcp_probe.start));
> +	struct timespec64 ts
> +		= ktime_to_timespec64(ktime_sub(p->tstamp, tcp_probe.start));
>  
>  	return scnprintf(tbuf, n,
>  			"%lu.%09lu %pISpc %pISpc %d %#x %#x %u %u %u %u %u\n",
> -			(unsigned long)tv.tv_sec,
> -			(unsigned long)tv.tv_nsec,
> +			(unsigned long)ts.tv_sec,
> +			(unsigned long)ts.tv_nsec,
>  			&p->src, &p->dst, p->length, p->snd_nxt, p->snd_una,
>  			p->snd_cwnd, p->ssthresh, p->snd_wnd, p->srtt, p->rcv_wnd);
>  }
> 

-- 
Hideaki Yoshifuji <hideaki.yoshifuji@...aclelinux.com>
Technical Division, MIRACLE LINUX CORPORATION