netdev - Re: [Patch net-next] net: remove skb_sender_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D492E7.4060900@iogearbox.net>
Date:	Mon, 29 Feb 2016 19:50:15 +0100
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Cong Wang <xiyou.wangcong@...il.com>
CC:	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [Patch net-next] net: remove skb_sender_cpu_clear()

On 02/28/2016 05:19 AM, Cong Wang wrote:
> After commit 52bd2d62ce67 ("net: better skb->sender_cpu and skb->napi_id cohabitation")
> skb_sender_cpu_clear() becomes empty and can be removed.
>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Wasn't the intention to keep this helper as a marker when packet
crosses domains from RX to TX, see discussion here:

   https://patchwork.ozlabs.org/patch/527167/

Maybe better to rename it and add a comment into the helper to
make the intention more clear?