netdev - Re: net-next build failure due to 16e5cc64?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXwd9fQqEh1o56fVqoxUYC5ctY9wqjkAA7UeGru+T8bjw@mail.gmail.com>
Date:	Tue, 1 Mar 2016 10:23:44 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Sowmini Varadhan <sowmini.varadhan@...cle.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	john fastabend <john.fastabend@...il.com>,
	John Fastabend <john.r.fastabend@...el.com>
Subject: Re: net-next build failure due to 16e5cc64?

On Tue, Mar 1, 2016 at 10:21 AM, Sowmini Varadhan
<sowmini.varadhan@...cle.com> wrote:
> On (03/01/16 10:13), Cong Wang wrote:
>> > net/sched/sch_mqprio.c: In function `mqprio_init':
>> > net/sched/sch_mqprio.c:145: error: unknown field `tc' specified in initializer
>     :
>> Why not just initialize these fields explicitly? For example,
>>
>> +       struct tc_to_netdev tc;
>              :
>> +       tc.type = TC_SETUP_MQPRIO;
>
> The compiler error is for fields within the union which lacks
> both a tag and a union-name.  So I'm not sure how the above will
> help.
>

Come on.. we have plenty of such anonymous unions in skbuff.h...