netdev - Re: net-next build failure due to 16e5cc64?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160301190917.GU16369@oracle.com>
Date:	Tue, 1 Mar 2016 14:09:17 -0500
From:	Sowmini Varadhan <sowmini.varadhan@...cle.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	john fastabend <john.fastabend@...il.com>,
	John Fastabend <john.r.fastabend@...el.com>
Subject: Re: net-next build failure due to 16e5cc64?

On (03/01/16 10:51), Cong Wang wrote:
> --- a/net/sched/sch_mqprio.c
> +++ b/net/sched/sch_mqprio.c
> @@ -142,7 +142,7 @@ static int mqprio_init(struct Qdisc *sch, struct
> nlattr *opt)
>          */
>         if (qopt->hw) {
>                 struct tc_to_netdev tc = {.type = TC_SETUP_MQPRIO,
> -                                         .tc = qopt->num_tc};
> +                                         {.tc = qopt->num_tc} };
> 

this fix works.

The first suggestion had no effect (needs changes to a lot of files
I suspect).

BTW, I remain surprised that no one else has noticed this. It did not
take me any effort to reproduce it on an x86.

--Sowmini