netdev - Re: [PATCH net-next] ethtool.h: define DIV_ROUND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1456862806.3098.161.camel@decadent.org.uk>
Date:	Tue, 01 Mar 2016 20:06:46 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	nicolas.dichtel@...nd.com, netdev@...r.kernel.org,
	nikolay@...ulusnetworks.com, kan.liang@...el.com
Subject: Re: [PATCH net-next] ethtool.h: define DIV_ROUND_UP for userland

On Tue, 2016-03-01 at 14:48 -0500, David Miller wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Tue, 01 Mar 2016 17:14:06 +0000
> 
> > On Tue, 2016-03-01 at 11:42 -0500, David Miller wrote:
> >> From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> >> Date: Tue,  1 Mar 2016 16:20:41 +0100
> >> 
> >> > DIV_ROUND_UP and is defined in linux/kernel.h only for the kernel. INT_MAX
> >> > needs limits.h in userland.
> >> 
> >> It is wrong to provide a definition of this in the user visible global
> >> namespace.
> > 
> > Which is why he's not doing that...
> 
> No, that's exactly what he's doing:
> 
> +#ifndef __KERNEL__
> +#include <limits.h> /* for INT_MAX */
> +#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
> +#endif
> 
> in a uapi header file.
> 
> "If not kernel, define DEV_ROUND_UP"

Sorry, as there was already a v2 which doesn't do this, I thought you
were responding to that.

Ben.

-- 
Ben Hutchings
If God had intended Man to program,
we'd have been born with serial I/O ports.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)