netdev - Re: [PATCH net-next v3 0/5] bridge/ovs: avoid skb head copy on frame forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160301.155450.1254691266298262681.davem@davemloft.net>
Date:	Tue, 01 Mar 2016 15:54:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pshelar@....org
Cc:	pabeni@...hat.com, netdev@...r.kernel.org,
	stephen@...workplumber.org, pshelar@...ira.com, jesse@...nel.org,
	fbl@...close.org, hannes@...essinduktion.org,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH net-next v3 0/5] bridge/ovs: avoid skb head copy on
 frame forwarding

From: pravin shelar <pshelar@....org>
Date: Mon, 29 Feb 2016 11:05:18 -0800

> On Fri, Feb 26, 2016 at 1:45 AM, Paolo Abeni <pabeni@...hat.com> wrote:
>> Currently, while when an OVS or Linux bridge is used to forward frames towards
>> some tunnel device, a skb_head_copy() may occur if the ingress device do not
>> provide enough headroom for the tx encapsulation.
>>
>> This patch series tries to address the issue implementing a new ndo operation to
>> allow the master device to control the headroom used when allocating the skb on
>> frame reception.
>>
>> Said operation is used by the Linux bridge to notify the bridged ports of
>> needed_headroom changes, and similar bookkeeping and behaviour is also added to
>> openvswitch, on a per datapath basis.
>>
>> Finally, the operation is implemented for veth and tun device, which give
>> performance improvement in the 6-12% range when forwarding frames from said
>> devices towards a vxlan tunnel.
>>
>> v2:
>> - fix netdev_get_fwd_headroom() behaviour
>> - remove some code duplication with the netdev_set_rx_headroom() and
>>    netdev_reset_rx_headroom() helpers
>> - handle headroom reset on [v]port removal/deletion
>> - initialize tun align to the old default value
>>
>> v3:
>> - fix a comment typo
>>
> Patch series looks good to me.
> 
> Acked-by: Pravin B Shelar <pshelar@....org>

Series applied, thanks everyone.