netdev - Re: [PATCH net] sctp: lack the check for ports in sctp_v6_cmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160301.172551.1571133128115239882.davem@davemloft.net>
Date:	Tue, 01 Mar 2016 17:25:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	lucien.xin@...il.com
Cc:	netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
	marcelo.leitner@...il.com, vyasevich@...il.com,
	daniel@...earbox.net
Subject: Re: [PATCH net] sctp: lack the check for ports in sctp_v6_cmp_addr

From: Xin Long <lucien.xin@...il.com>
Date: Sun, 28 Feb 2016 10:03:51 +0800

> As the member .cmp_addr of sctp_af_inet6, sctp_v6_cmp_addr should also check
> the port of addresses, just like sctp_v4_cmp_addr, cause it's invoked by
> sctp_cmp_addr_exact().
> 
> Now sctp_v6_cmp_addr just check the port when two addresses have different
> family, and lack the port check for two ipv6 addresses. that will make
> sctp_hash_cmp() cannot work well.
> 
> so fix it by adding ports comparison in sctp_v6_cmp_addr().
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thanks.