netdev - Re: [PATCH net] sctp: sctp_remaddr_seq_show use the wrong variable to dump transport info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160301.173613.295919796621489412.davem@davemloft.net>
Date:	Tue, 01 Mar 2016 17:36:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	lucien.xin@...il.com
Cc:	netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
	marcelo.leitner@...il.com, vyasevich@...il.com,
	daniel@...earbox.net
Subject: Re: [PATCH net] sctp: sctp_remaddr_seq_show use the wrong variable
 to dump transport info

From: Xin Long <lucien.xin@...il.com>
Date: Sun, 28 Feb 2016 10:33:11 +0800

> Now in sctp_remaddr_seq_show(), we use variable *tsp to get the param *v.
> but *tsp is also used to traversal transport_addr_list, which will cover
> the previous value, and make sctp_transport_put work on the wrong transport.
> 
> So fix it by adding a new variable to get the param *v.
> 
> Fixes: fba4c330c5b9 ("sctp: hold transport before we access t->asoc in sctp proc")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thanks.