netdev - Re: [PATCH] of_mdio: kill useless variable in of_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160301.174200.926566152360746618.davem@davemloft.net>
Date:	Tue, 01 Mar 2016 17:42:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	grant.likely@...aro.org, robh+dt@...nel.org,
	devicetree@...r.kernel.org, f.fainelli@...il.com,
	netdev@...r.kernel.org, frowand.list@...il.com
Subject: Re: [PATCH] of_mdio: kill useless variable in of_mdiobus_register()

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Sun, 28 Feb 2016 21:56:34 +0300

> of_mdiobus_register()  declares the 'paddr' variable to hold the result of
> the of_get_property()  but only uses it once after that while the function
> can be called directly from the *if* statement. Remove that variable and
> switch to calling of_find_property() instead since  we don't care about
> the "reg" property's value anyway...
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 
> ---
> The patch is against DaveM's 'net-next.git' repo.

Applied.