netdev - Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1456846276.3098.156.camel@decadent.org.uk>
Date:	Tue, 01 Mar 2016 15:31:16 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	sixiao@...rosoft.com, kys@...rosoft.com, haiyangz@...rosoft.com,
	devel@...uxdriverproject.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get
 of settings

On Mon, 2016-02-29 at 17:50 -0500, David Miller wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Mon, 29 Feb 2016 22:34:38 +0000
> 
> > On Mon, 2016-02-29 at 17:09 -0500, David Miller wrote:
> >> From: Simon Xiao <sixiao@...rosoft.com>
> >> Date: Thu, 25 Feb 2016 15:24:08 -0800
> >> 
> >> > This patch allows the user to set and retrieve speed and duplex of the
> >> > hv_netvsc device via ethtool.
> >> > 
> >> > Example:
> >> > $ ethtool eth0
> >> > Settings for eth0:
> >> > ...
> >> >     Speed: Unknown!
> >> >     Duplex: Unknown! (255)
> >> > ...
> >> > $ ethtool -s eth0 speed 1000 duplex full
> >> > $ ethtool eth0
> >> > Settings for eth0:
> >> > ...
> >> >     Speed: 1000Mb/s
> >> >     Duplex: Full
> >> > ...
> >> > 
> >> > This is based on patches by Roopa Prabhu and Nikolay Aleksandrov.
> >> > 
> >> > Signed-off-by: Simon Xiao <sixiao@...rosoft.com>
> >> 
> >> Applied, thanks.
> > 
> > I missed this due to flu, but now I look at it - I don't see the point.
> > Link speed isn't meaingful for a memory-based transport, so "unknown"
> > is correct.  The link is effectively full duplex though.
> > 
> > If the issue is that ethtool is a bit shouty about unknowns, let's
> > consider changing that in ethtool, not teaching drivers to lie.
> 
> The issue is that certain bonding modes do not work properly without
> a speed being reported by a device.

Ah, of course.

> We're doing this for other "virtual" devices already thanks to changes
> that went in last week, so there is precedence.

I know, just wasn't convinced it was a good precedent.

Ben.

-- 
Ben Hutchings
If God had intended Man to program,
we'd have been born with serial I/O ports.
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)