lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Mar 2016 10:26:27 -0800 From: Cong Wang <xiyou.wangcong@...il.com> To: Kyeong Yoo <Kyeong.Yoo@...iedtelesis.co.nz> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Jamal Hadi Salim <jhs@...atatu.com> Subject: Re: net_sched: dsmark: use qdisc_dequeue_peeked() On Tue, Mar 1, 2016 at 8:10 PM, Kyeong Yoo <Kyeong.Yoo@...iedtelesis.co.nz> wrote: > This fix is for dsmark similar to 3557619f0f6f7496ed453d4825e24958ab1884e0, > and makes use of qdisc_dequeue_peeked() instead of direct dequeue() call. > > First time, wrr peeks dsmark, which will then peek into sfq. > sfq dequeues an skb and it's stored in sch->gso_skb. > Next time, wrr tries to dequeue from dsmark, which will call sfq dequeue > directly. This results skipping the previously peeked skb. > > So changed dsmark dequeue to call qdisc_dequeue_peeked() instead to use > peeked skb if exists. This part looks reasonable to me. > > Also replaced dsmark peek to use qdisc_peek_dequeued() which works correctly > if previously peeked skb still exists. But not this part, since sfq already calls qdisc_peek_dequeued()?
Powered by blists - more mailing lists