netdev - Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160302051405.M6687@cooldavid.org>
Date:	Wed, 2 Mar 2016 13:14:55 +0800
From:	"Guo-Fu Tseng" <cooldavid@...ldavid.org>
To:	David Miller <davem@...emloft.net>, diego.viola@...il.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	richard.weinberger@...il.com, pavel@....cz, rjw@...ysocki.net,
	valdis.kletnieks@...edu
Subject: Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

On Wed, 24 Feb 2016 23:58:56 -0500 (EST), David Miller wrote
> From: Diego Viola <diego.viola@...il.com>
> Date: Tue, 23 Feb 2016 12:04:04 -0300
> 
> > The JMC260 network card fails to suspend/resume because the call to
> > jme_start_irq() was too early, moving the call to jme_start_irq() after
> > the call to jme_reset_link() makes it work.
> > 
> > Prior this change suspend/resume would fail unless /sys/power/pm_async=0
> > was explicitly specified.
> > 
> > Relevant bug report: https://bugzilla.kernel.org/show_bug.cgi?id=112351
> > 
> > Signed-off-by: Diego Viola <diego.viola@...il.com>
> 
> Applied and queued up for -stable, thanks.

Just reviewed it, it should have no side effect.

Thanks David, Diego.

Guo-Fu Tseng