netdev - Re: [PATCH v2] ethtool: check size of user memory before copying strings and stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1456915682.3098.164.camel@decadent.org.uk>
Date:	Wed, 02 Mar 2016 10:48:02 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	"Keller, Jacob E" <jacob.e.keller@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"Rustad, Mark D" <mark.d.rustad@...el.com>,
	"jeff@...zik.org" <jeff@...zik.org>,
	"mirq-linux@...e.qmqm.pl" <mirq-linux@...e.qmqm.pl>,
	"alexander.duyck@...il.com" <alexander.duyck@...il.com>
Subject: Re: [PATCH v2] ethtool: check size of user memory before copying
 strings and stats

On Wed, 2016-03-02 at 01:11 +0000, Keller, Jacob E wrote:
> On Wed, 2016-03-02 at 00:12 +0000, Ben Hutchings wrote:
> > NAK, ethtool is not the only consumer of the ethtool API.  How many
> > times do I have to repeat myself?
> > 
> > Ben.
> > 
> 
> Ok, so essentially forcing drivers to require static sets for the
> various stats/strings/etc?

No, you can define a new and better statistics API.  There are many
limitations of the current API that could be addressed at the same
time, e.g. lack of units, lack of hierarchy in naming, lack of
distinction between counters and other statistics.

Ben.

> :(
> 
> Will have patches to cleanup fm10k for this then.
> 
> Regards,
> Jake
-- 
Ben Hutchings
Tomorrow will be cancelled due to lack of interest.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)