netdev - Re: [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2016 13:27:59 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Brown <david.brown@...aro.org>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Lee Jones <lee.jones@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	driverdevel <devel@...verdev.osuosl.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Vinod Koul <vinod.koul@...el.com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Kishon Vijay Abraham I <kishon@...com>,
	Andy Gross <andy.gross@...aro.org>,
	Linux Media Mailing List <linux-media@...r.kernel.org>,
	Jason Cooper <jason@...edaemon.net>,
	RTCLINUX <rtc-linux@...glegroups.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Marc Zyngier <marc.zyngier@....com>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-soc@...r.kernel.org, Alessandro Zummo <a.zummo@...ertech.it>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux PM list <linux-pm@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	dmaengine@...r.kernel.org, David Woodhouse <dwmw2@...radead.org>
Subject: Re: [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on HAS_IOMEM

On Thu, Mar 3, 2016 at 11:55 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Thursday 03 March 2016 17:03:34 Krzysztof Kozlowski wrote:
>> index 0da40e2e4280..5c530b6b125d 100644
>> --- a/drivers/rtc/Kconfig
>> +++ b/drivers/rtc/Kconfig
>> @@ -1302,6 +1302,7 @@ config RTC_DRV_AT91RM9200
>>  config RTC_DRV_AT91SAM9
>>         tristate "AT91SAM9 RTT as RTC"
>>         depends on ARCH_AT91 || COMPILE_TEST
>> +       depends on HAS_IOMEM    # For MFD_SYSCON
>>         select MFD_SYSCON
>>         help
>>           Some AT91SAM9 SoCs provide an RTT (Real Time Timer) block which
>>
>
> This is technically correct, but the entire RTC menu is hidden
> inside of 'depends on !UML && !S390', so we won't ever get there
> on any configuration that does not use HAS_IOMEM.
>
> If we did, all other RTC drivers would also fail.

So UML has no RTC. Should/can it use RTC_DRV_GENERIC?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds