netdev - Re: [PATCH] stmmac: fix noderef.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D98374.6020003@st.com>
Date:	Fri, 4 Mar 2016 13:45:40 +0100
From:	Alexandre Torgue <alexandre.torgue@...com>
To:	kbuild test robot <fengguang.wu@...el.com>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>
CC:	<kbuild-all@...org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] stmmac: fix noderef.cocci warnings

Hi,

On 03/03/2016 02:55 AM, kbuild test robot wrote:
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:115:15-21: ERROR: application of sizeof to pointer
>
>   sizeof when applied to a pointer typed expression gives the size of
>   the pointer
>
> Generated by: scripts/coccinelle/misc/noderef.cocci
>
> CC: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>
>   stmmac_platform.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -112,7 +112,7 @@ static struct stmmac_axi *stmmac_axi_set
>   	if (!np)
>   		return NULL;
>
> -	axi = kzalloc(sizeof(axi), GFP_KERNEL);
> +	axi = kzalloc(sizeof(*axi), GFP_KERNEL);
>   	if (!axi)
>   		return ERR_PTR(-ENOMEM);
>
>


Thanks.
You can add my Acked-by: Alexandre Torgue <alexandre.torgue@...com>

-- 

Regards

Alex