netdev - Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D98F8F.5010700@cogentembedded.com>
Date:	Fri, 4 Mar 2016 16:37:19 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Daode Huang <huangdaode@...ilicon.com>, davem@...emloft.net
Cc:	liguozhu@...ilicon.com, Yisen.Zhuang@...wei.com,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, linuxarm@...wei.com,
	salil.mehta@...wei.com, kenneth-lee-2012@...mail.com,
	xuwei5@...ilicon.com, lisheng011@...wei.com, yankejian@...wei.com
Subject: Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt

Hello.

On 3/4/2016 4:09 AM, Daode Huang wrote:

> In V2 chip, when sending mamagement packets, the driver should
> config the port id to BD descs.
>
> Signed-off-by: Daode Huang <huangdaode@...ilicon.com>
> Signed-off-by: Lisheng <lisheng011@...wei.com>
> ---
>   drivers/net/ethernet/hisilicon/hns/hnae.h         | 3 +++
>   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 +
>   drivers/net/ethernet/hisilicon/hns/hns_enet.c     | 4 ++++
>   3 files changed, 8 insertions(+)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h b/drivers/net/ethernet/hisilicon/hns/hnae.h
> index 1cbcb9f..11a3f97 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hnae.h
> +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
[...]
> @@ -516,6 +518,7 @@ struct hnae_handle {
>   	int q_num;
>   	int vf_id;
>   	u32 eport_id;
> +	u32 dport_id;	/*v2 tx bd should fill the dport_id*/

    Please add spaces after /* and before */ (like it's done in other places 
in this driver).

[...]
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> index 6250a42..b45dcc2 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> @@ -69,6 +69,10 @@ static void fill_v2_desc(struct hnae_ring *ring, void *priv,
>   	hnae_set_bit(rrcfv, HNSV2_TXD_VLD_B, 1);
>   	hnae_set_field(bn_pid, HNSV2_TXD_BUFNUM_M, 0, buf_num - 1);
>
> +	/*fill port_id in the tx bd for sending management pkts*/

    Likewise.

> +	hnae_set_field(bn_pid, HNSV2_TXD_PORTID_M,
> +		       HNSV2_TXD_PORTID_S, ring->q->handle->dport_id);
> +
>   	if (type == DESC_TYPE_SKB) {
>   		skb = (struct sk_buff *)priv;
>

MBR, Sergei