netdev - Re: [PATCH 2/4] infiniband: hns: add Hisilicon RoCE support(binding)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D992E2.3060504@cogentembedded.com>
Date:	Fri, 4 Mar 2016 16:51:30 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	"Wei Hu(Xavier)" <xavier.huwei@...wei.com>, dledford@...hat.com,
	sean.hefty@...el.com, hal.rosenstock@...il.com,
	davem@...emloft.net, jeffrey.t.kirsher@...el.com,
	jiri@...lanox.com, ogerlitz@...lanox.com
Cc:	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, gongyangming@...wei.com,
	xiaokun@...wei.com, tangchaofei@...wei.com, oulijun@...wei.com,
	haifeng.wei@...wei.com, yisen.zhuang@...wei.com,
	yankejian@...wei.com, lisheng011@...wei.com,
	charles.chenxin@...wei.com, linuxarm@...wei.com
Subject: Re: [PATCH 2/4] infiniband: hns: add Hisilicon RoCE support(binding)

Hello.

On 3/4/2016 11:41 AM, Wei Hu(Xavier) wrote:

> This submit add binding file and dts file.
>
> Signed-off-by: Wei Hu(Xavier) <xavier.huwei@...wei.com>
> Signed-off-by: oulijun <oulijun@...wei.com>
> ---
>   .../bindings/infiniband/hisilicon-hns-roce.txt     | 68 ++++++++++++++++++++++
>   1 file changed, 68 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>
> diff --git a/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
> new file mode 100644
> index 0000000..8004641
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
> @@ -0,0 +1,68 @@
> +HiSilicon RoCE DT description
> +
> +HiSilicon RoCE engine is a part of network subsystem.
> +It works depending on other part of network wubsytem, such as, gmac and
> +dsa fabric.
> +
> +Additional properties are described here:
> +
> +Required properties:
> +- compatible: Should contain "hisilicon,hns-roce-v1".
> +- reg: Physical base address of the roce driver and
> +length of memory mapped region.
> +- eth-handle: phandle, specifies a reference to a node
> +representing a ethernet device.
> +- dsaf-handle: phandle, specifies a reference to a node
> +representing a dsaf device.
> +- #address-cells: must be 2
> +- #size-cells: must be 2
> +Optional properties:
> +- dma-coherent: Present if DMA operations are coherent.
> +- interrupt-parent: the interrupt parent of this device.
> +- interrupts: should contain 32 completion event irq,1 async event irq
> +and 1 event overflow irq.

    The "interrupt-names" prop is very desirable for so many interrupts.

> +Example:
> +	rocee@...4000000 {

    The node names should be generic and "0x" should be omitted, i.e. 
"infiniband@...00000".

MBR, Sergei