netdev - Re: [net-next] arp: correct return value of arp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <000f01d175b2$24117f50$6c347df0$@cmss.chinamobile.com>
Date:	Fri, 4 Mar 2016 09:06:53 +0800
From:	张胜举 <zhangshengju@...s.chinamobile.com>
To:	"'David Miller'" <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>
Subject: Re: [net-next] arp: correct return value of arp_rcv

> From: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Date: Tue,  1 Mar 2016 07:24:42 +0000
> 
> > Currently, arp_rcv() always return zero on a packet delivery upcall.
> >
> > To make its behavior more compliant with the way this API should be
> > used, this patch changes this to let it return NET_RX_SUCCESS when the
> > packet is proper handled, and NET_RX_DROP otherwise.
> >
> > Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> 
> This change is bogus.
> 
> > @@ -880,7 +880,7 @@ out:
> >  	consume_skb(skb);
> >  out_free_dst:
> >  	dst_release(reply_dst);
> > -	return 0;
> > +	return NET_RX_SUCCESS;
> 
> Most of the paths to out: are dropping the request for one reason or
> another.
> 
> If you want to do this right you need to split these two exit paths,
convert
> consume_skb() to kfree_skb() in the drop path, and then you can return
> accurate NET_* codes.

You are right, I will change this part and sent another version later.

Shengju