netdev - Re: [PATCH net-next V2 03/10] net/sched: Macro instead of CONFIG_NET_CLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpVDXoNrTq+51eYFQHXaztASsUP67wC3n3iCBDeeKf6QJA@mail.gmail.com>
Date:	Fri, 4 Mar 2016 10:20:18 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Amir Vadai <amir@...ai.me>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	John Fastabend <john.r.fastabend@...el.com>,
	Jiri Pirko <jiri@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Hadar Har-Zion <hadarh@...lanox.com>,
	Rony Efraim <ronye@...lanox.com>
Subject: Re: [PATCH net-next V2 03/10] net/sched: Macro instead of
 CONFIG_NET_CLS_ACT ifdef

On Thu, Mar 3, 2016 at 11:51 AM, Amir Vadai <amir@...ai.me> wrote:
> On Thu, Mar 03, 2016 at 09:45:28AM -0800, Cong Wang wrote:
>>
>> So why?
> The struct will not be used, and without exposing it, the compiler will
> complain on code like I have in patch 9/10 ("net/mlx5e: Support offload
> cls_flower with drop action"):
>
> static int parse_tc_actions(struct mlx5e_priv *priv, struct tcf_exts *exts,
>                             u32 *action, u32 *flow_tag)

Why not make this a nop when CONFIG_NET_CLS_ACT is not set?