netdev - Re: [PATCH 00/13] RxRPC: Rewrite part 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160304.172010.571829527806753588.davem@davemloft.net>
Date:	Fri, 04 Mar 2016 17:20:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dhowells@...hat.com
Cc:	linux-afs@...ts.infradead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/13] RxRPC: Rewrite part 1

From: David Howells <dhowells@...hat.com>
Date: Fri, 04 Mar 2016 16:37:05 +0000

> Here's the first set of patches from my RxRPC rewrite, aimed at net-next.
> These do some clean ups and bug fixes.  Most of the changes are small, but
> there are a couple of bigger changes:
> 
>  (*) Convert call flag numbers and event numbers into enums.  Then rename
>      the event numbers to all have _EV_ in their name to stop confusion.
>      Fix one instance of an event bit being used instead of a flag bit.
> 
>  (*) A copy of the Rx protocol header is kept in the sk_buff private data.
>      Keep this in host byte order rather than network byte order as it
>      makes more sense.  A number of other fields then get converted into
>      host byte order too.
> 
>      Conversion between host and network byte order is then done at the
>      packet reception/generation stage.
> 
> The patches can be found here also:
> 
> 	http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite
> 
> Tagged thusly:
> 
> 	git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
> 	rxrpc-rewrite-20160304
> 
> This is based on net-next/master

This looks really nice, pulled, thanks a lot David.

Can you go through and use "unsigned int" instead of just plain
"unsigned" in the RxRPC code?

Thanks.