netdev - Suspicious code in tun_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1457132684-16118-1-git-send-email-khoroshilov@ispras.ru>
Date:	Sat,  5 Mar 2016 02:04:44 +0300
From:	Alexey Khoroshilov <khoroshilov@...ras.ru>
To:	Eric Dumazet <edumazet@...gle.com>,
	Greg Kurz <gkurz@...ux.vnet.ibm.com>,
	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Alexey Khoroshilov <khoroshilov@...ras.ru>,
	David Gibson <david@...son.dropbear.id.au>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Suspicious code in tun_flow_update()

Hello,

If tun_flow_find() successfully finds tun_flow_entry,
tun_flow_update() updates the entry in place.

Is such usage of RCU safe here?

Found by Linux Driver Verification project (linuxtesting.org).

--
Alexey Khoroshilov
Linux Verification Center, ISPRAS