netdev - Re: [ethtool PATCH v2 10/12] internal.h: TRUE/FALSE macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1457066116.4044.125.camel@perches.com>
Date:	Thu, 03 Mar 2016 20:35:16 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Decotigny <ddecotig@...il.com>, netdev@...r.kernel.org
Cc:	Jeff Garzik <jgarzik@...ox.com>,
	Ben Hutchings <ben@...adent.org.uk>,
	David Miller <davem@...hat.com>,
	Vidya Sagar Ravipati <vidya@...ulusnetworks.com>,
	David Decotigny <decot@...glers.com>
Subject: Re: [ethtool PATCH v2 10/12] internal.h: TRUE/FALSE macros

On Thu, 2016-03-03 at 20:23 -0800, David Decotigny wrote:
> From: David Decotigny <decot@...glers.com>
[]
> diff --git a/internal.h b/internal.h
[]
> @@ -42,6 +42,14 @@ typedef int32_t s32;
>  #include "ethtool-copy.h"
>  #include "net_tstamp-copy.h"
>  
> +#ifndef TRUE
> +#  define TRUE (!0)
> +#endif
> +
> +#ifndef FALSE
> +#  define FALSE (!!0)

#define TRUE 1
and
#define FALSE 0
are obvious and typical.

The ! and !! uses don't add anything other than obscurity.