netdev - Re: [PATCH 1/1] be2net: Don't leak iomapped memory on removal.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Mar 2016 10:30:35 +0530
From:	Sathya Perla <sathya.perla@...adcom.com>
To:	Douglas Miller <dougmill@...ux.vnet.ibm.com>
Cc:	netdev@...r.kernel.org,
	Ajit Kumar Khaparde <ajit.khaparde@...adcom.com>,
	Padmanabh Ratnakar <padmanabh.ratnakar@...adcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
	Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH 1/1] be2net: Don't leak iomapped memory on removal.

On Fri, Mar 4, 2016 at 4:05 AM, Douglas Miller
<dougmill@...ux.vnet.ibm.com> wrote:
> The adapter->pcicfg resource is either mapped via pci_iomap() or
> derived from adapter->db. During be_remove() this resource was ignored
> and so could remain mapped after remove.
>
> Add a flag to track whether adapter->pcicfg was mapped or not, then
> use that flag in be_unmap_pci_bars() to unmap if required.
>
> Signed-off-by: Douglas Miller <dougmill@...ux.vnet.ibm.com>

Acked-by: Sathya Perla <sathya.perla@...adcom.com>

Could you pls add the "fixes" tag line to this patch:
Fixes: 25848c901 ("use PCI MMIO read instead of config read for errors")

thanks for the fix,
-Sathya