[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160306125604.7978a1d9@xeon-e3>
Date: Sun, 6 Mar 2016 12:56:04 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc: netdev@...r.kernel.org, roopa@...ulusnetworks.com
Subject: Re: [PATCH iproute2 net-next] bridge: mdb: add support for extended
router port information
On Thu, 3 Mar 2016 16:19:34 +0100
Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote:
> +static int is_temp_mcast_rtr(__u8 type)
> {
> + if (type == MDB_RTR_TYPE_TEMP_QUERY || type == MDB_RTR_TYPE_TEMP)
> + return 1;
> + else
> + return 0;
> +}
> +
Minor style issues, why not much simpler:
static bool is_tmp_mcast_rtr(__u8 type)
{
return (type == MDB_RTR_TYPE_TEMP_QUERY || type == MDB_RTR_TYPE_TEMP);
}
Powered by blists - more mailing lists