netdev - Re: [PATCH net] bridge: a netlink notification should be sent whenever those attributes change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_czyyD2G5FimeBrS=WQ80BEeJb8_rVgkLD5wQErwJMhxQ@mail.gmail.com>
Date:	Sun, 6 Mar 2016 14:08:49 +0800
From:	Xin Long <lucien.xin@...il.com>
To:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:	network dev <netdev@...r.kernel.org>, davem <davem@...emloft.net>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH net] bridge: a netlink notification should be sent
 whenever those attributes change

On Sun, Mar 6, 2016 at 3:43 AM, Nikolay Aleksandrov
<nikolay@...ulusnetworks.com> wrote:
> On 03/05/2016 03:44 PM, Xin Long wrote:
>
> See the comment above dev_ifsioc:
> /*
>  *      Perform the SIOCxIFxxx calls, inside rtnl_lock()
>  */
> static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd)
> {
> ...
> it is usually called like:
>                        rtnl_lock();
>                        ret = dev_ifsioc(net, &ifr, cmd);
>                        rtnl_unlock();
> And also you cannot be calling netdevice notifiers without RTNL. So in any
> case you do need it here as well, in fact you'll surely hit the ASSERT_RTNL();
> in call_netdevice_notifiers_info if you do so, thus I'm not sure how this
> patch was actually tested.
>
yes, I can see it now.
I will repost this patch with rtnl_lock in br_sysfs_*.
Thanks Nik.

>