netdev - Re: [ethtool PATCH v3 10/12] internal.h: TRUE/FALSE macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1457367136.15205.29.camel@decadent.org.uk>
Date:	Mon, 07 Mar 2016 16:12:16 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Decotigny <ddecotig@...il.com>, netdev@...r.kernel.org
Cc:	Jeff Garzik <jgarzik@...ox.com>, David Miller <davem@...hat.com>,
	Vidya Sagar Ravipati <vidya@...ulusnetworks.com>,
	Joe Perches <joe@...ches.com>,
	David Decotigny <decot@...glers.com>
Subject: Re: [ethtool PATCH v3 10/12] internal.h: TRUE/FALSE macros

On Fri, 2016-03-04 at 16:42 -0800, David Decotigny wrote:

> From: David Decotigny <decot@...glers.com>
> 
> 
> Signed-off-by: David Decotigny <decot@...glers.com>
> ---
>  internal.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/internal.h b/internal.h
> index 5df8124..7c44d0e 100644
> --- a/internal.h
> +++ b/internal.h
> @@ -42,6 +42,14 @@ typedef int32_t s32;
>  #include "ethtool-copy.h"
>  #include "net_tstamp-copy.h"
>  
> +#ifndef TRUE
> +#  define TRUE 1
> +#endif
> +
> +#ifndef FALSE
> +#  define FALSE 0
> +#endif

I'd much prefer true and false as defined in <stdbool.h>.

Ben.

>  #if __BYTE_ORDER == __BIG_ENDIAN
>  static inline u16 cpu_to_be16(u16 value)
>  {
-- 
Ben Hutchings
The most exhausting thing in life is being insincere. - Anne Morrow Lindberg
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)