netdev - Re: [PATCH net,stable] cdc_ncm: toggle altsetting to force reset before setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160307.143811.474380372887861694.davem@davemloft.net>
Date:	Mon, 07 Mar 2016 14:38:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bjorn@...k.no
Cc:	oliver@...kum.org, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH net,stable] cdc_ncm: toggle altsetting to force reset
 before setup

From: Bjørn Mork <bjorn@...k.no>
Date: Thu,  3 Mar 2016 22:20:53 +0100

> Some devices will silently fail setup unless they are reset first.
> This is necessary even if the data interface is already in
> altsetting 0, which it will be when the device is probed for the
> first time.  Briefly toggling the altsetting forces a function
> reset regardless of the initial state.
> 
> This fixes a setup problem observed on a number of Huawei devices,
> appearing to operate in NTB-32 mode even if we explicitly set them
> to NTB-16 mode.
> 
> Signed-off-by: Bjørn Mork <bjorn@...k.no>

Applied and queued up for -stable, thanks.