netdev - Re: [net-next v2] arp: correct return value of arp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160307.145517.292313609973580675.davem@davemloft.net>
Date:	Mon, 07 Mar 2016 14:55:17 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	zhangshengju@...s.chinamobile.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next v2] arp: correct return value of arp_rcv

From: Zhang Shengju <zhangshengju@...s.chinamobile.com>
Date: Fri,  4 Mar 2016 14:07:54 +0000

> Currently, arp_rcv() always return zero on a packet delivery upcall.
> 
> To make its behavior more compliant with the way this API should be
> used, this patch changes this to let it return NET_RX_SUCCESS when the
> packet is proper handled, and NET_RX_DROP otherwise.
> 
> v1->v2:
> If sanity check is failed, call kfree_skb() instead of consume_skb(), then
> return the correct return value.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>

Applied, thanks.