netdev - Re: [PATCH net-next 1/1] tipc: remove pre-allocated message header in link struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160306.230150.2115988710117845238.davem@davemloft.net>
Date:	Sun, 06 Mar 2016 23:01:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jon.maloy@...csson.com
Cc:	netdev@...r.kernel.org, paul.gortmaker@...driver.com,
	parthasarathy.bhuvaragan@...csson.com, richard.alpe@...csson.com,
	ying.xue@...driver.com, maloy@...jonn.com,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 1/1] tipc: remove pre-allocated message header
 in link struct

From: Jon Maloy <jon.maloy@...csson.com>
Date: Thu,  3 Mar 2016 14:23:21 -0500

> Until now, we have kept a pre-allocated protocol message header
> aggregated into struct tipc_link. Apart from adding unnecessary
> footprint to the link instances, this requires extra code both to
> initialize and re-initialize it.
> 
> We now remove this sub-optimization. This change also makes it
> possible to clean up the function tipc_build_proto_msg() and remove
> a couple of small functions that were accessing the mentioned header.
> In particular, we can replace all occurrences of the local function
> call link_own_addr(link) with the generic tipc_own_addr(net).
> 
> Acked-by: Ying Xue <ying.xue@...driver.com>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied, thanks.