netdev - Question concerning function illegal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <56DEAA3A.4080207@marvell.com>
Date:	Tue, 8 Mar 2016 11:32:26 +0100
From:	Lino Sanfilippo <lsanfil@...vell.com>
To:	<netdev@...r.kernel.org>
CC:	Lino Sanfilippo <LinoSanfilippo@....de>,
	<linux-kernel@...r.kernel.org>
Subject: Question concerning function illegal_highdma

Hi all,

while trying to understand the meaning of the net_device flag NETIF_F_HIGHDMA
I came across the function illegal_highdma() which seems to perform two tasks:

1. Check if a network interface is able to handle high memory pages
2. Check if a network interface is able to handle the resulting DMA addresses

What I dont understand is why both conditions are only checked if CONFIG_HIGHMEM is set.
For 1. this makes sense, of course. But why is 2. also only checked with CONFIG_HIGHMEM?
Should not 2. always be checked, regardless of whether high memory exists in the system or not?

Thanks for any enlightenment in advance!

Regards,
Lino