netdev - Re: [PATCH net-next v3] net_sched: dsmark: use qdisc_dequeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160308.143612.780302416140653742.davem@davemloft.net>
Date:	Tue, 08 Mar 2016 14:36:12 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	kyeong.yoo@...iedtelesis.co.nz
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] net_sched: dsmark: use
 qdisc_dequeue_peeked()

From: Kyeong Yoo <kyeong.yoo@...iedtelesis.co.nz>
Date: Mon, 07 Mar 2016 17:07:57 +1300

> This fix is for dsmark similar to commit 3557619f0f6f7496ed453d4825e249
> ("net_sched: prio: use qdisc_dequeue_peeked")
> and makes use of qdisc_dequeue_peeked() instead of direct dequeue() call.
> 
> First time, wrr peeks dsmark, which will then peek into sfq.
> sfq dequeues an skb and it's stored in sch->gso_skb.
> Next time, wrr tries to dequeue from dsmark, which will call sfq dequeue
> directly. This results skipping the previously peeked skb.
> 
> So changed dsmark dequeue to call qdisc_dequeue_peeked() instead to use
> peeked skb if exists.
> 
> Signed-off-by: Kyeong Yoo <kyeong.yoo@...iedtelesis.co.nz>

Applied, thank you.