netdev - Re: [RFC PATCH net-next v2] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160308.152444.555296214200726963.davem@davemloft.net>
Date:	Tue, 08 Mar 2016 15:24:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mleitner@...hat.com
Cc:	kafai@...com, netdev@...r.kernel.org, kernel-team@...com,
	rapier@....edu, edumazet@...gle.com, ncardwell@...gle.com,
	ycheng@...gle.com
Subject: Re: [RFC PATCH net-next v2] tcp: Add RFC4898
 tcpEStatsPerfDataSegsOut/In

From: Marcelo Ricardo Leitner <mleitner@...hat.com>
Date: Tue, 8 Mar 2016 16:41:54 -0300

> On Mon, Mar 07, 2016 at 06:01:05PM -0800, Martin KaFai Lau wrote:
>> v2:
>> Rework based on recent fix by Eric:
>> commit a9d99ce28ed3 ("tcp: fix tcpi_segs_in after connection establishment")
>> 
>> v1:
> 
> Patch itself looks good to me, just this patch history is better placed
> on the Notes region (together with the diffstat) or place a scissors
> mark, otherwise it will be present in the git changelog too.

I like seeing it in the commit message.

Then later people can figure out answers to questions like "why didn't you
implement this like X" and see in the version history that this was
attempted first and then intentionally changed.

I even move version history into the commit message when people try to
move it out, so please don't do that.

This is important _especially_ for "0/N" header postings for a patch
series.

DO NOT LOSE INFORMATION.