netdev - Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56DEA840.1050305@st.com>
Date:	Tue, 8 Mar 2016 11:24:00 +0100
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Gabriel Fernandez <gabriel.fernandez@...aro.org>,
	Dinh Nguyen <dinh.linux@...il.com>
CC:	Andreas Färber <afaerber@...e.de>,
	Heiko Stübner <heiko@...ech.de>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	<netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	LAKML <linux-arm-kernel@...ts.infradead.org>,
	Alexandre TORGUE <alexandre.torgue@...com>,
	Fabrice GASNIER <fabrice.gasnier@...com>
Subject: Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

On 3/8/2016 11:03 AM, Gabriel Fernandez wrote:
> Hi Andreas and Dinh  Thanks for your feedback i will check it.

hmm, I was looking at the code and indeed I have some doubt on
mdio_bus_data management that the patch changes explaining
why the Andreas's box fails and phy_add is not detected.

Keep the sync

peppe


> Best regards
>
> Gabriel
>
> On 8 March 2016 at 00:22, Dinh Nguyen <dinh.linux@...il.com> wrote:
>> On Mon, Mar 7, 2016 at 11:15 AM, Andreas Färber <afaerber@...e.de> wrote:
>>> Am 07.03.2016 um 16:52 schrieb Giuseppe CAVALLARO:
>>>> On 3/7/2016 4:46 PM, Andreas Färber wrote:
>>>>> Am 07.03.2016 um 16:09 schrieb Giuseppe CAVALLARO:
>>>>>> On 3/7/2016 3:27 PM, Andreas Färber wrote:
>>>>>>> Indeed, reverting Gabriel's commit fixes the observed error messages
>>>>> [...]
>>>>>>> However, I am unable to ping any hosts on the network now.
>>>>>>
>>>>>> hmm, this could be another problem. I wonder if you can
>>>>>> check which recent patch is introducing the problem on ARM64.
>>>>>> For example if this depends on Oct_2015 update.
>>>>>
>>>>> I've had success reverting drivers/net/ethernet/stmicro/ up to and
>>>>> including "stmmac: first frame prep at the end of xmit routine", i.e.
>>>>> top 7 commits.
>>>>
>>>> Andreas, I will check it and let you know asap.
>>>
>>> I verified that it's just these two commits that I need to revert:
>>>
>>> "stmmac: Fix 'eth0: No PHY found' regression"
>>> "stmmac: first frame prep at the end of xmit routine"
>>>
>>> Those in between don't cause conflicts and seem to work okay.
>>>
>>
>> I'm seeing the same issue on the SoCFPGA platform:
>>
>> libphy: PHY stmmac-0:ffffffff not found
>> eth0: Could not attach to PHY
>> stmmac_open: Cannot attach to PHY (error: -19)
>>
>> If I just revert:
>>
>>   "stmmac: Fix 'eth0: No PHY found' regression"
>>
>> then the issue goes away.
>>
>> Thanks,
>> Dinh
>
>