netdev - Re: [RFC] xfrm: netdevice unregistration during decryption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160309022045.GA29265@gondor.apana.org.au>
Date:	Wed, 9 Mar 2016 10:20:45 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	subashab@...eaurora.org
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	netdev@...r.kernel.org
Subject: Re: [RFC] xfrm: netdevice unregistration during decryption

On Tue, Mar 08, 2016 at 07:16:23PM -0700, subashab@...eaurora.org wrote:
>
> 2. Encrypted packet queued for decryption (asynchronous)
> 
> static int esp_input(struct xfrm_state *x, struct sk_buff *skb)
> ...
>          aead_request_set_callback(req, 0, esp_input_done, skb);

I suppose we'll have to hold onto the device at this point.  We
may have to hold onto other resources too.

> Would it make sense here to detect the device going away here using a
> netdev notifier callback and free the packets after the asynchronous
> callback returns.

The same path is used for synchronous processing so you can't just
change it to netif_rx_ni unconditionally.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt