netdev - Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56DFFA9E.7060602@st.com>
Date:	Wed, 9 Mar 2016 11:27:42 +0100
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Tomeu Vizoso <tomeu@...euvizoso.net>,
	Fabrice GASNIER <fabrice.gasnier@...com>
CC:	Dinh Nguyen <dinh.linux@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Heiko Stübner <heiko@...ech.de>,
	<netdev@...r.kernel.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	LAKML <linux-arm-kernel@...ts.infradead.org>,
	Andreas Färber <afaerber@...e.de>,
	Gabriel Fernandez <gabriel.fernandez@...aro.org>,
	Alexandre TORGUE <alexandre.torgue@...com>,
	Frank Schäfer <fschaefer.oss@...glemail.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

Hello Tomeu, Andreas,

On 3/9/2016 10:52 AM, Giuseppe CAVALLARO wrote:
>> * today's linux-next: probe failed
>>
>> * today's linux-next + revert of 88f8b1bb41c6 stmmac: Fix 'eth0: No
>> PHY found' regression: probe succeeded but no network at all
>>
>> * today's linux-next + revert of 88f8b1bb41c6 (stmmac: Fix 'eth0: No
>> PHY found' regression) + revert of 0e80bdc9a72d (stmmac: first frame
>> prep at the end of xmit routine): probe succeeded, dhcp succeeds and
>> nfsroot works for a few seconds before timing out
>
> ok, I was looking at this problem now that seems to related
> the "stmmac: first frame prep at the end of xmit routine"
> that, at first glance, is breaking the gmac 3.50 with normal descriptor.

I have no Hw where to test this use case. So, I wonder if may I ask you 
to test some patch.

This first patch adds a missing barrier to the normal routine that inits 
the descriptor. Barrier was needed to well manage the OWN
descriptor and it was not added in case of normal desc case after
the xmit rework.

Then I will check the algo behind the new xmit and in case of problems,
if you agree, we will decide to revert it because it aimed to add an
optimization.

Let me know if you agree.

Regards
Peppe

View attachment "normal_tmp.patch" of type "text/x-patch" (951 bytes)