lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 09 Mar 2016 11:53:29 +0100 From: Daniel Borkmann <daniel@...earbox.net> To: Tom Herbert <tom@...bertland.com> CC: "David S. Miller" <davem@...emloft.net>, Alexei Starovoitov <alexei.starovoitov@...il.com>, Thomas Graf <tgraf@...g.ch>, Linux Kernel Network Developers <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 2/4] vxlan: support setting IPv6 flow label On 03/09/2016 04:29 AM, Tom Herbert wrote: [...] >> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h >> index d452cea..6bebc97 100644 >> --- a/include/uapi/linux/if_link.h >> +++ b/include/uapi/linux/if_link.h >> @@ -456,6 +456,7 @@ enum { >> IFLA_VXLAN_GBP, >> IFLA_VXLAN_REMCSUM_NOPARTIAL, >> IFLA_VXLAN_COLLECT_METADATA, >> + IFLA_VXLAN_LABEL, > > Should this interface align with ip_gre that uses IFLA_GRE_FLOWINFO to > set both traffic class and flow label in one shot? For vxlan and geneve by the way, there's already IFLA_VXLAN_TOS and IFLA_GENEVE_TOS attribute that configure the tos for IPv4 or traffic class for IPv6 case on the device, and have special handling in the xmit path that they can inherit the tos/tc when configured as such on the device in non collect metadata case. Seems like grev6 is handled differently and also still without tunnel key support, if I see this correctly. Agree with you that some more consolidation would be nice. >> __IFLA_VXLAN_MAX >> }; >> #define IFLA_VXLAN_MAX (__IFLA_VXLAN_MAX - 1) >> -- >> 1.9.3
Powered by blists - more mailing lists