netdev - Re: [PATCH] mrf24j40: fix security-enabled processing on inbound frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56E1A38F.6050108@osg.samsung.com>
Date:	Thu, 10 Mar 2016 17:40:47 +0100
From:	Stefan Schmidt <stefan@....samsung.com>
To:	Alan Ott <alan@...nal11.us>, zopieux <web@...ieux.com>,
	linux-wpan@...r.kernel.org
Cc:	netdev@...r.kernel.org, Alexander Aring <alex.aring@...il.com>
Subject: Re: [PATCH] mrf24j40: fix security-enabled processing on inbound
 frames

Hello.

On 29/02/16 20:49, Alan Ott wrote:
> On 02/18/2016 01:34 PM, zopieux wrote:
>> Fix the MRF24J40 handling of security-enabled frames so it does not
>> block upon receiving such frames.
>>
>> Signed-off-by: Alexander Aring <aar@...gutronix.de>
>> Reported-by: Alexandre Macabies <web+oss@...ieux.com>
>> Tested-by: Alexandre Macabies <web+oss@...ieux.com>
>> ---
>> When receiving a security-enabled IEEE 802.15.4 frame, the MRF24J40
>> triggers a SECIF interrupt that needs to be handled for RX processing
>> to keep functioning properly.
>>
>> This patch enables the SECIF interrupt and makes the MRF ignores all
>> hardware processing of security-enabled frames, that is handled by the
>> ieee802154 stack instead.
>> ---
>
> The "From" field of the email needs to have your real name in it. This 
> will be where the "Author" field in git comes from.
>
> It looks like there are a few separate things happening in this patch. 
> Maybe they should be broken out in to separate patches. I see:
>
> 1. The ieee802154.h part,
> 2. The TX part,
> 3. The RX part.
>
> The patch description only really describes the RX part.
>

zopieux, could you split the patch as Alan suggested and re-submitted 
the series?

regards
Stefan Schmidt