netdev - Re: [PATCH net-next] bpf: bpf_stackmap_copy depends on CONFIG_PERF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160309.232803.2152242260458545384.davem@davemloft.net>
Date:	Wed, 09 Mar 2016 23:28:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ast@...com
Cc:	daniel@...earbox.net, fengguang.wu@...el.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bpf: bpf_stackmap_copy depends on
 CONFIG_PERF_EVENTS

From: Alexei Starovoitov <ast@...com>
Date: Wed, 9 Mar 2016 18:56:49 -0800

> 0-day bot reported build error:
> kernel/built-in.o: In function `map_lookup_elem':
>>> kernel/bpf/.tmp_syscall.o:(.text+0x329b3c): undefined reference to `bpf_stackmap_copy'
> when CONFIG_BPF_SYSCALL is set and CONFIG_PERF_EVENTS is not.
> Add weak definition to resolve it.
> This code path in map_lookup_elem() is never taken
> when CONFIG_PERF_EVENTS is not set.
> 
> Fixes: 557c0c6e7df8 ("bpf: convert stackmap to pre-allocation")
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>

Applied.