netdev - Re: [PATCH v2 net-next 1/2] net: hns: fix return value of the function about rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201603102149.TSoRVG6b%fengguang.wu@intel.com>
Date:	Thu, 10 Mar 2016 21:26:16 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Kejian Yan <yankejian@...wei.com>
Cc:	kbuild-all@...org, davem@...emloft.net, yisen.zhuang@...wei.com,
	salil.mehta@...wei.com, liguozhu@...wei.com,
	huangdaode@...ilicon.com, arnd@...db.de,
	andriy.shevchenko@...ux.intel.com, andrew@...n.ch,
	chenny.xu@...wei.com, ivecera@...hat.com, lisheng011@...wei.com,
	fengguang.wu@...el.com, haifeng.wei@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linuxarm@...wei.com
Subject: Re: [PATCH v2 net-next 1/2] net: hns: fix return value of the
 function about rss

Hi Kejian,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Kejian-Yan/net-hns-get-and-set-RSS-indirection-table-by-using-ethtool/20160310-210648
config: x86_64-allyesconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/hisilicon/hns/hns_ethtool.c: In function 'hns_get_rss':
>> drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:1214:6: warning: unused variable 'ret' [-Wunused-variable]
     int ret;
         ^
   drivers/net/ethernet/hisilicon/hns/hns_ethtool.c: In function 'hns_set_rss':
   drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:1236:6: warning: unused variable 'ret' [-Wunused-variable]
     int ret;
         ^

vim +/ret +1214 drivers/net/ethernet/hisilicon/hns/hns_ethtool.c

6bc0ce7d Salil      2015-12-03  1198  		netdev_err(netdev,
6bc0ce7d Salil      2015-12-03  1199  			   "RSS feature is not supported on this hardware\n");
73f4f566 Kejian Yan 2016-03-10  1200  		return (u32)-EOPNOTSUPP;
6bc0ce7d Salil      2015-12-03  1201  	}
6bc0ce7d Salil      2015-12-03  1202  
6bc0ce7d Salil      2015-12-03  1203  	ops = priv->ae_handle->dev->ops;
6bc0ce7d Salil      2015-12-03  1204  	ret = ops->get_rss_indir_size(priv->ae_handle);
6bc0ce7d Salil      2015-12-03  1205  
6bc0ce7d Salil      2015-12-03  1206  	return ret;
6bc0ce7d Salil      2015-12-03  1207  }
6bc0ce7d Salil      2015-12-03  1208  
6bc0ce7d Salil      2015-12-03  1209  static int
6bc0ce7d Salil      2015-12-03  1210  hns_get_rss(struct net_device *netdev, u32 *indir, u8 *key, u8 *hfunc)
6bc0ce7d Salil      2015-12-03  1211  {
6bc0ce7d Salil      2015-12-03  1212  	struct hns_nic_priv *priv = netdev_priv(netdev);
6bc0ce7d Salil      2015-12-03  1213  	struct hnae_ae_ops *ops;
6bc0ce7d Salil      2015-12-03 @1214  	int ret;
6bc0ce7d Salil      2015-12-03  1215  
6bc0ce7d Salil      2015-12-03  1216  	if (AE_IS_VER1(priv->enet_ver)) {
6bc0ce7d Salil      2015-12-03  1217  		netdev_err(netdev,
6bc0ce7d Salil      2015-12-03  1218  			   "RSS feature is not supported on this hardware\n");
6bc0ce7d Salil      2015-12-03  1219  		return -EOPNOTSUPP;
6bc0ce7d Salil      2015-12-03  1220  	}
6bc0ce7d Salil      2015-12-03  1221  
6bc0ce7d Salil      2015-12-03  1222  	ops = priv->ae_handle->dev->ops;

:::::: The code at line 1214 was first introduced by commit
:::::: 6bc0ce7d9adabf332afc102f7f97bf121b990ece net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

:::::: TO: Salil <salil.mehta@...wei.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (52478 bytes)